Skip to content

fix: stream generator type #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-sanche merged 1 commit into from
Dec 19, 2025
Merged

fix: stream generator type #1148

daniel-sanche merged 1 commit into from
Dec 19, 2025

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Dec 18, 2025

Fixes #1080 🦕

@daniel-sanche daniel-sanche requested review from a team as code owners December 18, 2025 22:12
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 18, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Dec 18, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a precise type hint correction within the StreamGenerator class. By updating the __iter__ method's return annotation to StreamGenerator[T], the change ensures accurate type-checking for generic stream generators, resolving a specific issue related to type definition and improving overall code clarity and maintainability.

Highlights

  • Type Hint Correction: Corrected the type hint for the __iter__ method within the StreamGenerator class to properly include the generic type T.
  • Issue Resolution: This change directly addresses and fixes the issue reported in https://github.com/googleapis/python-firestore/issues/1080.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@daniel-sanche daniel-sanche mentioned this pull request Dec 18, 2025
Closed
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 18, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the return type hint for the __iter__ method in the StreamGenerator class. By specifying StreamGenerator[T], the type hint is now more precise for this generic class, improving type safety. The change is accurate and I have no further recommendations.

@daniel-sanche daniel-sanche merged commit 165d367 into main Dec 19, 2025
24 checks passed
@daniel-sanche daniel-sanche deleted the fix_stream_type branch December 19, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pcostell pcostell

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Iterating StreamGenerator yields Unknown type

3 participants

@daniel-sanche @vchudnov-g @pcostell